linux-mips
[Top] [All Lists]

[PATCH 02/59] CRED: Wrap task credential accesses in the MIPS arch

To: linux-kernel@vger.kernel.org
Subject: [PATCH 02/59] CRED: Wrap task credential accesses in the MIPS arch
From: David Howells <dhowells@redhat.com>
Date: Wed, 27 Aug 2008 14:45:52 +0100
Cc: linux-security-module@vger.kernel.org, David Howells <dhowells@redhat.com>, Serge Hallyn <serue@us.ibm.com>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <20080827134541.19980.61042.stgit@warthog.procyon.org.uk>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080827134541.19980.61042.stgit@warthog.procyon.org.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: StGIT/0.14.3
Wrap access to task credentials so that they can be separated more easily from
the task_struct during the introduction of COW creds.

Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

Change some task->e?[ug]id to task_e?[ug]id().  In some places it makes more
sense to use RCU directly rather than a convenient wrapper; these will be
addressed by later patches.

Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: James Morris <jmorris@namei.org>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
---

 arch/mips/kernel/mips-mt-fpaff.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


diff --git a/arch/mips/kernel/mips-mt-fpaff.c b/arch/mips/kernel/mips-mt-fpaff.c
index df4d3f2..928c72b 100644
--- a/arch/mips/kernel/mips-mt-fpaff.c
+++ b/arch/mips/kernel/mips-mt-fpaff.c
@@ -51,6 +51,7 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, 
unsigned int len,
        int retval;
        struct task_struct *p;
        struct thread_info *ti;
+       uid_t euid;
 
        if (len < sizeof(new_mask))
                return -EINVAL;
@@ -76,9 +77,9 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, 
unsigned int len,
         */
        get_task_struct(p);
 
+       euid = current_euid();
        retval = -EPERM;
-       if ((current->euid != p->euid) && (current->euid != p->uid) &&
-                       !capable(CAP_SYS_NICE)) {
+       if (euid != p->euid && euid != p->uid && !capable(CAP_SYS_NICE)) {
                read_unlock(&tasklist_lock);
                goto out_unlock;
        }


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 02/59] CRED: Wrap task credential accesses in the MIPS arch, David Howells <=