linux-mips
[Top] [All Lists]

Re: [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 3/6] rb532: do not KSEG1ADDR an already virtual address
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Fri, 22 Aug 2008 13:41:16 +0400
Cc: linux-mips <linux-mips@linux-mips.org>, ralf@linux-mips.org
In-reply-to: <200808220014.39030.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200808220014.39030.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (Windows/20080708)
Hello.

Florian Fainelli wrote:
This patch removes the superfluous double KSEG1ADDR
against the base register in the setup code.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/arch/mips/rb532/setup.c b/arch/mips/rb532/setup.c
index 7aafa95..6d3286e 100644
--- a/arch/mips/rb532/setup.c
+++ b/arch/mips/rb532/setup.c
@@ -10,6 +10,7 @@
 #include <linux/ioport.h>
#include <asm/mach-rc32434/rc32434.h>
+#include <asm/mach-rc32434/rb.h>
 #include <asm/mach-rc32434/pci.h>
struct pci_reg __iomem *pci_reg;
@@ -27,7 +28,7 @@ static struct resource pci0_res[] = {
 static void rb_machine_restart(char *command)
 {
        /* just jump to the reset vector */
-       writel(0x80000001, (void *)KSEG1ADDR(RC32434_REG_BASE + RC32434_RST));
+       writel(0x80000001, (void *)KSEG1ADDR(REG_BASE + RC32434_RST));

Why not just leave RC32434_REG_BASE + RC32434_RST and remove KSEG1ADDR? BTW, the cast could be removed as well, since it's already a part of RC32434_REG_BASE...

WBR, Sergei



<Prev in Thread] Current Thread [Next in Thread>