linux-mips
[Top] [All Lists]

[PATCH 5/6] rb532: replace volatile rough read with a readl

To: "linux-mips" <linux-mips@linux-mips.org>
Subject: [PATCH 5/6] rb532: replace volatile rough read with a readl
From: Florian Fainelli <florian@openwrt.org>
Date: Fri, 22 Aug 2008 00:15:01 +0200
Cc: ralf@linux-mips.org
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
This patch replaces a rough read using volatiles
with a readl.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c
index 3d1632c..d44a703 100644
--- a/arch/mips/rb532/gpio.c
+++ b/arch/mips/rb532/gpio.c
@@ -70,7 +70,7 @@ void set_434_reg(unsigned reg_offs, unsigned bit, unsigned 
len, unsigned val)
 
        spin_lock_irqsave(&dev3.lock, flags);
 
-       data = *(volatile unsigned *) (IDT434_REG_BASE + reg_offs);
+       data = readl(IDT434_REG_BASE + reg_offs);
        for (i = 0; i != len; ++i) {
                if (val & (1 << i))
                        data |= (1 << (i + bit));

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 5/6] rb532: replace volatile rough read with a readl, Florian Fainelli <=