linux-mips
[Top] [All Lists]

Re: [MIPS] msp71xx: resolve compilation problem in msp_setup.c

To: Shane McDonald <mcdonald.shane@gmail.com>
Subject: Re: [MIPS] msp71xx: resolve compilation problem in msp_setup.c
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 18 Aug 2008 22:28:12 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <E1KUmPs-0005uZ-Du@localhost>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <E1KUmPs-0005uZ-Du@localhost>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Aug 17, 2008 at 11:51:48AM -0600, Shane McDonald wrote:
> From: Shane McDonald <mcdonald.shane@gmail.com>
> Date: Sun, 17 Aug 2008 11:51:48 -0600
> To: linux-mips@linux-mips.org, ralf@linux-mips.org
> Subject: [MIPS] msp71xx: resolve compilation problem in msp_setup.c
> 
> The msp71xx_defconfig has never compiled in a kernel release.  This is
> because the file msp_setup.c relies on some definitions from the PMCMSP
> GPIO driver, which has not yet been accepted into the kernel.
> This patch checks for the existence of the PMCMSP GPIO driver;
> if it doesn't exist, no GPIO functions are referenced.
> 
> This patch will continue to work after the GPIO driver has been accepted,
> so no changes will be necessary when that happens.

Has the driver actually been submitted?  In its current form I doubt it'll
be accepted since there is now a generic GPIO framework so there should
be no more new drivers/char/ GPIO drivers.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>