| To: | Dave Hansen <dave@linux.vnet.ibm.com> |
|---|---|
| Subject: | Re: sparsemem support for mips with highmem |
| From: | C Michael Sundius <Michael.sundius@sciatl.com> |
| Date: | Thu, 14 Aug 2008 16:16:28 -0700 |
| Authentication-results: | sj-dkim-2; header.From=Michael.sundius@sciatl.com; dkim=neutral |
| Cc: | linux-mm@kvack.org, linux-mips@linux-mips.org, jfraser@broadcom.com, Andy Whitcroft <apw@shadowen.org> |
| In-reply-to: | <1218753308.23641.56.camel@nimitz> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <48A4AC39.7020707@sciatl.com> <1218753308.23641.56.camel@nimitz> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 2.0.0.14 (X11/20080501) |
yaknow, there are several loops in this file that look through this boot_mem_ map structure. they all have the same basic form (but of course are slightly different). Anyhow, I just cut and pasted. I'm wondering if the MIPS folks have comment on how best to make this change and possibly clean up this file. I'm happy to do it, but think I'd like some+ if (boot_mem_map.map[i].type != BOOT_MEM_RAM) + continue; + + start = PFN_UP(boot_mem_map.map[i].addr); + end = PFN_DOWN(boot_mem_map.map[i].addr + + boot_mem_map.map[i].size); + + memory_present(0, start, end); + } }Is that aligning really necessary? I'm just curious because if it is, it would probably be good to stick it inside memory_present(). guidance on this... anyone?I'll fix and resubmit. sorry for posting this to the two lists, but I wasn't sure if I should put it on the linux-mm list or the linux-mips list... I'll keep the distribution unless I her complaints. mike |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Debugging the MIPS processor using GDB (and FS2 EJTAG probe breakpoint issues), Maciej W. Rozycki |
|---|---|
| Next by Date: | Re: sparsemem support for mips with highmem, C Michael Sundius |
| Previous by Thread: | Re: sparsemem support for mips with highmem, Dave Hansen |
| Next by Thread: | Re: sparsemem support for mips with highmem, C Michael Sundius |
| Indexes: | [Date] [Thread] [Top] [All Lists] |