linux-mips
[Top] [All Lists]

Re: [PATCH] DS1286: new RTC driver

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] DS1286: new RTC driver
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 7 Aug 2008 10:12:33 +0100
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, rtc-linux@googlegroups.com, linux-mips@linux-mips.org
In-reply-to: <Pine.LNX.4.64.0808071102420.23641@anakin>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080803174137.AF8071DA6F4@solo.franken.de> <20080807105249.50d6e777@i1501.lan.towertech.it> <Pine.LNX.4.64.0808071102420.23641@anakin>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Aug 07, 2008 at 11:03:07AM +0200, Geert Uytterhoeven wrote:

> > > + priv = kzalloc(sizeof *priv, GFP_KERNEL);
> > 
> >  sizeof(struct ds1286_priv) is a little bit cleaner.
> 
> What if the type of priv changes?

Then this code will more changes anyway ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>