linux-mips
[Top] [All Lists]

Re: [PATCH] DS1286: new RTC driver

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] DS1286: new RTC driver
From: Alessandro Zummo <alessandro.zummo@towertech.it>
Date: Thu, 7 Aug 2008 11:12:38 +0200
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>, rtc-linux@googlegroups.com, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <Pine.LNX.4.64.0808071102420.23641@anakin>
Organization: Tower Technologies
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080803174137.AF8071DA6F4@solo.franken.de> <20080807105249.50d6e777@i1501.lan.towertech.it> <Pine.LNX.4.64.0808071102420.23641@anakin>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 7 Aug 2008 11:03:07 +0200 (CEST)
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> >  sizeof(struct ds1286_priv) is a little bit cleaner.  
> 
> What if the type of priv changes?

 It shouldn't in such a small context . however, it is not required,
 is just my personal preference about readability.

 parentheses around the sizeof are, ont he other side, required.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


<Prev in Thread] Current Thread [Next in Thread>