linux-mips
[Top] [All Lists]

Re: [PATCH] DS1286: new RTC driver

To: Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [PATCH] DS1286: new RTC driver
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 7 Aug 2008 11:03:07 +0200 (CEST)
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>, rtc-linux@googlegroups.com, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20080807105249.50d6e777@i1501.lan.towertech.it>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080803174137.AF8071DA6F4@solo.franken.de> <20080807105249.50d6e777@i1501.lan.towertech.it>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 7 Aug 2008, Alessandro Zummo wrote:
> On Sun,  3 Aug 2008 19:41:37 +0200 (CEST)
> Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote:
> > +static int __devinit ds1286_probe(struct platform_device *pdev)
> > +{
> > +   struct rtc_device *rtc;
> > +   struct resource *res;
> > +   struct ds1286_priv *priv;
> > +   int ret = 0;
> > +
> > +   res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +   if (!res)
> > +           return -ENODEV;
> > +   priv = kzalloc(sizeof *priv, GFP_KERNEL);
> 
>  sizeof(struct ds1286_priv) is a little bit cleaner.

What if the type of priv changes?

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>