linux-mips
[Top] [All Lists]

Re: [PATCH] METH: fix MAC address setup

To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] METH: fix MAC address setup
From: Jeff Garzik <jgarzik@pobox.com>
Date: Thu, 07 Aug 2008 02:12:21 -0400
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20080730231424.CD5E8DEBB8@solo.franken.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080730231424.CD5E8DEBB8@solo.franken.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.14 (X11/20080501)
Thomas Bogendoerfer wrote:
Setup of the mac filter lost the upper 16bit of the mac address. This
bug got unconvered by a patch, which fixed the promiscous handling.

Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---

 drivers/net/meth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/meth.c b/drivers/net/meth.c
index 4cb364e..0a97c26 100644
--- a/drivers/net/meth.c
+++ b/drivers/net/meth.c
@@ -100,7 +100,7 @@ static inline void load_eaddr(struct net_device *dev)
        DPRINTK("Loading MAC Address: %s\n", print_mac(mac, dev->dev_addr));
        macaddr = 0;
        for (i = 0; i < 6; i++)
-               macaddr |= dev->dev_addr[i] << ((5 - i) * 8);
+               macaddr |= (u64)dev->dev_addr[i] << ((5 - i) * 8);

applied



<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] METH: fix MAC address setup, Jeff Garzik <=