linux-mips
[Top] [All Lists]

Re: [PATCH] [MIPS] Add USB device (OTG) support for Au1200 and Au1250

To: Kevin Hickey <khickey@rmicorp.com>
Subject: Re: [PATCH] [MIPS] Add USB device (OTG) support for Au1200 and Au1250
From: Manuel Lauss <mano@roarinelk.homelinux.net>
Date: Tue, 05 Aug 2008 11:38:30 +0200
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <1217881052-18797-2-git-send-email-khickey@rmicorp.com>
Organization: Private
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <> <1217881052-18797-1-git-send-email-khickey@rmicorp.com> <1217881052-18797-2-git-send-email-khickey@rmicorp.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.16 (X11/20080726)
Hi Kevin,

Kevin Hickey wrote:
This patch adds support for the USB Device controller on the Au1200 and Au1250.

Awesome!


With this patch, only basic device mode is supported; full On-The-Go
functionality will be completed in a later release.  Two new drivers are
included; au1200_udc is the USB Device Controller driver and au1200_otg is the
portmux driver.  The portmux driver determines the mode of operation for the
port based on software and hardware selectors.  Currently, it only supports
device mode.

These drivers have been tested on a DB1200 board using the g_file_storage 
gadget.

Apart from the usual condingstyle nits (run it through scripts/checkpatch.pl 
please),
there's one thing: The GPIO code in the uoc header must go away.  Pass function
pointers to enable/disable VBUS through platform data, but don't modify GPIOs
directly (i.e. get rid of all code which assumes its running on DB1200).

You should also CC linux-usb ML.

Thanks,
        Manuel Lauss


<Prev in Thread] Current Thread [Next in Thread>