Re: [PATCH] [MIPS] Add USB device (OTG) support for Au1200 and Au1250

[Manuel Lauss <mano@roarinelk.homelinux.net>]

Hi Kevin,

Kevin Hickey wrote:
> This patch adds support for the USB Device controller on the Au1200 and Au1250.
Awesome!


> With this patch, only basic device mode is supported; full On-The-Go
> functionality will be completed in a later release.  Two new drivers are
> included; au1200_udc is the USB Device Controller driver and au1200_otg is the
> portmux driver.  The portmux driver determines the mode of operation for the
> port based on software and hardware selectors.  Currently, it only supports
> device mode.
>
> These drivers have been tested on a DB1200 board using the g_file_storage 
> gadget.
Apart from the usual condingstyle nits (run it through scripts/checkpatch.pl 
please),
there's one thing: The GPIO code in the uoc header must go away.  Pass function
pointers to enable/disable VBUS through platform data, but don't modify GPIOs
directly (i.e. get rid of all code which assumes its running on DB1200).

You should also CC linux-usb ML.

Thanks,
        Manuel Lauss