[Top] [All Lists]

Re: [PATCH 1/1] Char: ds1286, eliminate busy waiting

To: Jiri Slaby <>
Subject: Re: [PATCH 1/1] Char: ds1286, eliminate busy waiting
From: Ralf Baechle <>
Date: Tue, 29 Jul 2008 00:05:33 +0100
Cc: Andrew Morton <>,,
In-reply-to: <>
Original-recipient: rfc822;
References: <>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Jul 25, 2008 at 07:49:58PM +0200, Jiri Slaby wrote:

> ds1286_get_time(); is not called from atomic context, sleep for 20 ms is
> better choice than a (home-made) busy waiting for such a situation.
> Signed-off-by: Jiri Slaby <>
> Cc: Ralf Baechle <>

Looks ok to me I guess.  Though I don't really think it matters ...

Acked-by: Ralf Baechle <>

The same condition also appears in drivers/char/rtc.c and maybe a few
others.  Rtc.c has been copies and modified several times.


<Prev in Thread] Current Thread [Next in Thread>