| To: | Jiri Slaby <jirislaby@gmail.com> |
|---|---|
| Subject: | Re: [PATCH 1/1] Char: ds1286, eliminate busy waiting |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Tue, 29 Jul 2008 00:05:33 +0100 |
| Cc: | Andrew Morton <akpm@linux-foundation.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org |
| In-reply-to: | <1217008198-17143-1-git-send-email-jirislaby@gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1217008198-17143-1-git-send-email-jirislaby@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, Jul 25, 2008 at 07:49:58PM +0200, Jiri Slaby wrote: > ds1286_get_time(); is not called from atomic context, sleep for 20 ms is > better choice than a (home-made) busy waiting for such a situation. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > Cc: Ralf Baechle <ralf@linux-mips.org> Looks ok to me I guess. Though I don't really think it matters ... Acked-by: Ralf Baechle <ralf@linux-mips.org> The same condition also appears in drivers/char/rtc.c and maybe a few others. Rtc.c has been copies and modified several times. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2 1/1][MIPS] Initialization of Alchemy boards, Ralf Baechle |
|---|---|
| Next by Date: | Committed_AS showing erroneous value, Anirban Sinha |
| Previous by Thread: | [PATCH 1/1] Char: ds1286, eliminate busy waiting, Jiri Slaby |
| Next by Thread: | Re: [PATCH 1/1] Char: ds1286, eliminate busy waiting, Jiri Slaby |
| Indexes: | [Date] [Thread] [Top] [All Lists] |