linux-mips
[Top] [All Lists]

Re: [PATCH 1/1] Initialization of Alchemy boards

To: Kevin Hickey <khickey@rmicorp.com>
Subject: Re: [PATCH 1/1] Initialization of Alchemy boards
From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Date: Mon, 28 Jul 2008 17:16:08 +0300
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <1217254063.9208.3.camel@kh-ubuntu.razamicroelectronics.com>
Organization: Movial Creative Technologies
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1217002430.10968.30.camel@kh-ubuntu.razamicroelectronics.com> <488D707A.4090800@movial.fi> <1217254063.9208.3.camel@kh-ubuntu.razamicroelectronics.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Icedove 1.5.0.14eol (X11/20080509)
Kevin Hickey wrote:
> Dmitri,
> 
> On Mon, 2008-07-28 at 10:08 +0300, Dmitri Vorobiev wrote:
>> Kevin Hickey wrote:
>>> I found this when I updated to version 2.6.26.  None of my development
>>> boards would boot.  It appears that a previous update changed some calls
>>> to simple_strtol to strict_strtol but did not account for the different
>>> call semantics.
>> Hi Kevin,
>>
>> 1) you forgot to sign your patch off;
> Indeed I did.  Is it sufficient to reply to the original post and add a
> sign-off line?

Well, I think it would be better to recreate the diff. What you have now does 
not apply:

dvorobye@sd048:/work/zoo/src/linux-2.6$ git apply

[pasted the patch]

error: mips/au1000/pb1000/init.c: No such file or directory
error: mips/au1000/pb1100/init.c: No such file or directory
error: mips/au1000/pb1200/init.c: No such file or directory
error: mips/au1000/mtx-1/init.c: No such file or directory
error: mips/au1000/pb1500/init.c: No such file or directory
error: mips/au1000/xxs1500/init.c: No such file or directory
error: mips/au1000/pb1550/init.c: No such file or directory
error: mips/au1000/db1x00/init.c: No such file or directory
dvorobye@sd048:/work/zoo/src/linux-2.6$

For a quick intro to creating the kernel patches, please see 
Documentation/SubmittingPatches, which describes the gitless approach. However, 
as I mentioned earlier, using git is much better.

Thanks,
Dmitri

<Prev in Thread] Current Thread [Next in Thread>