linux-mips
[Top] [All Lists]

Re: [PATCH 1/1] Initialization of Alchemy boards

To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Subject: Re: [PATCH 1/1] Initialization of Alchemy boards
From: Kevin Hickey <khickey@rmicorp.com>
Date: Mon, 28 Jul 2008 09:07:43 -0500
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <488D707A.4090800@movial.fi>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1217002430.10968.30.camel@kh-ubuntu.razamicroelectronics.com> <488D707A.4090800@movial.fi>
Sender: linux-mips-bounce@linux-mips.org
Dmitri,

On Mon, 2008-07-28 at 10:08 +0300, Dmitri Vorobiev wrote:
> Kevin Hickey wrote:
> > I found this when I updated to version 2.6.26.  None of my development
> > boards would boot.  It appears that a previous update changed some calls
> > to simple_strtol to strict_strtol but did not account for the different
> > call semantics.
> 
> Hi Kevin,
> 
> 1) you forgot to sign your patch off;
Indeed I did.  Is it sufficient to reply to the original post and add a
sign-off line?
> 2) please consider using git to generate and submit patches. At least 
> according to my experience, it's much more convenient than any other approach.
It's starting to look that way to me.  I started my work here using SVN
because that's what I'm familiar with.  I did some reading about git
this weekend and I think I'm going to adopt it for future kernel
development.
> 3) As I can see, the board-specific code is almost identical for the pb1x00 
> boards. While at it, would you please try to merge it?
Yes, but in a future patch.  I'd like to get this one accepted ASAP
because it prevents 2.6.26+ from booting on any of our development
boards.  Next, I want to go through all of the db and pb board specific
code and see if I can condense any of it.
> 
> Regards,
> Dmitri
Thanks,
Kevin
> 
> > 
> > Index: arch/mips/au1000/pb1000/init.c
> > ===================================================================
> > --- arch/mips/au1000/pb1000/init.c
> > +++ arch/mips/au1000/pb1000/init.c
> > @@ -52,6 +52,6 @@
> >     if (!memsize_str)
> >             memsize = 0x04000000;
> >     else
> > -           memsize = strict_strtol(memsize_str, 0, NULL);
> > +           strict_strtol(memsize_str, 0, &memsize);
> >     add_memory_region(0, memsize, BOOT_MEM_RAM);
> >  }
> > Index: arch/mips/au1000/pb1100/init.c
> > ===================================================================
> > --- arch/mips/au1000/pb1100/init.c
> > +++ arch/mips/au1000/pb1100/init.c
> > @@ -54,7 +54,7 @@
> >     if (!memsize_str)
> >             memsize = 0x04000000;
> >     else
> > -           memsize = strict_strtol(memsize_str, 0, NULL);
> > +           strict_strtol(memsize_str, 0, &memsize);
> >  
> >     add_memory_region(0, memsize, BOOT_MEM_RAM);
> >  }
> > Index: arch/mips/au1000/pb1200/init.c
> > ===================================================================
> > --- arch/mips/au1000/pb1200/init.c
> > +++ arch/mips/au1000/pb1200/init.c
> > @@ -53,6 +53,6 @@
> >     if (!memsize_str)
> >             memsize = 0x08000000;
> >     else
> > -           memsize = strict_strtol(memsize_str, 0, NULL);
> > +           strict_strtol(memsize_str, 0, &memsize);
> >     add_memory_region(0, memsize, BOOT_MEM_RAM);
> >  }
> > Index: arch/mips/au1000/mtx-1/init.c
> > ===================================================================
> > --- arch/mips/au1000/mtx-1/init.c
> > +++ arch/mips/au1000/mtx-1/init.c
> > @@ -55,6 +55,6 @@
> >     if (!memsize_str)
> >             memsize = 0x04000000;
> >     else
> > -           memsize = strict_strtol(memsize_str, 0, NULL);
> > +           strict_strtol(memsize_str, 0, &memsize);
> >     add_memory_region(0, memsize, BOOT_MEM_RAM);
> >  }
> > Index: arch/mips/au1000/pb1500/init.c
> > ===================================================================
> > --- arch/mips/au1000/pb1500/init.c
> > +++ arch/mips/au1000/pb1500/init.c
> > @@ -53,6 +53,6 @@
> >     if (!memsize_str)
> >             memsize = 0x04000000;
> >     else
> > -           memsize = strict_strtol(memsize_str, 0, NULL);
> > +           strict_strtol(memsize_str, 0, &memsize);
> >     add_memory_region(0, memsize, BOOT_MEM_RAM);
> >  }
> > Index: arch/mips/au1000/xxs1500/init.c
> > ===================================================================
> > --- arch/mips/au1000/xxs1500/init.c
> > +++ arch/mips/au1000/xxs1500/init.c
> > @@ -53,6 +53,6 @@
> >     if (!memsize_str)
> >             memsize = 0x04000000;
> >     else
> > -           memsize = strict_strtol(memsize_str, 0, NULL);
> > +           strict_strtol(memsize_str, 0, &memsize);
> >     add_memory_region(0, memsize, BOOT_MEM_RAM);
> >  }
> > Index: arch/mips/au1000/pb1550/init.c
> > ===================================================================
> > --- arch/mips/au1000/pb1550/init.c
> > +++ arch/mips/au1000/pb1550/init.c
> > @@ -53,6 +53,6 @@
> >     if (!memsize_str)
> >             memsize = 0x08000000;
> >     else
> > -           memsize = strict_strtol(memsize_str, 0, NULL);
> > +           strict_strtol(memsize_str, 0, &memsize);
> >     add_memory_region(0, memsize, BOOT_MEM_RAM);
> >  }
> > Index: arch/mips/au1000/db1x00/init.c
> > ===================================================================
> > --- arch/mips/au1000/db1x00/init.c
> > +++ arch/mips/au1000/db1x00/init.c
> > @@ -57,6 +57,6 @@
> >     if (!memsize_str)
> >             memsize = 0x04000000;
> >     else
> > -           memsize = strict_strtol(memsize_str, 0, NULL);
> > +           strict_strtol(memsize_str, 0, &memsize);
> >     add_memory_region(0, memsize, BOOT_MEM_RAM);
> >  }
> > 
> 
-- 
Kevin Hickey
Alchemy Solutions
RMI Corporation
khickey@RMICorp.com
P: 512.691.8044

<Prev in Thread] Current Thread [Next in Thread>