linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core

To: jason.wessel@windriver.com
Subject: Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Mon, 28 Jul 2008 23:05:12 +0900 (JST)
Cc: linux-kernel@vger.kernel.org, ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20080725.235233.130241768.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080725.012748.108121457.anemo@mba.ocn.ne.jp> <488941C5.9060908@windriver.com> <20080725.235233.130241768.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 25 Jul 2008 23:52:33 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> 
wrote:
> > It seem ok to me to try it.  Here is version 3 of the patch, which I was 
> > going to send to Ralf.
> 
> Thanks, it works for me with serial_txx9 kgdboc module.

BTW, is FRAME_POINTER mandatory for kgdb?  I agree that FRAME_POINTER
(ie. -fno-omit-frame-pointer -fno-optimize-sibling-calls) helps source
level debugging, but I think transparency is more important.

Now kgdboc can be loaded/activated at run-time, so I want to enable
CONFIG_KGDB usually.  But CONFIG_FRAME_POINTER introduces runtime
overhead on overall kernel, which is too bad (at least on MIPS).

Also, selecting FRAME_POINTER (which is not selectable on MIPS)
unconditionally looks somewhat inconsistent.

So ... Is this patch reasonable?


Subject: kgdb: Do not select FRAME_POINTER on MIPS

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/lib/Kconfig.kgdb b/lib/Kconfig.kgdb
index a5d4b1d..cc61bf0 100644
--- a/lib/Kconfig.kgdb
+++ b/lib/Kconfig.kgdb
@@ -7,7 +7,7 @@ config HAVE_ARCH_KGDB
 
 menuconfig KGDB
        bool "KGDB: kernel debugging with remote gdb"
-       select FRAME_POINTER
+       select FRAME_POINTER if !MIPS
        depends on HAVE_ARCH_KGDB
        depends on DEBUG_KERNEL && EXPERIMENTAL
        help

<Prev in Thread] Current Thread [Next in Thread>