linux-mips
[Top] [All Lists]

Re: [PATCH 1/1] Initialization of Alchemy boards

To: Kevin Hickey <khickey@rmicorp.com>
Subject: Re: [PATCH 1/1] Initialization of Alchemy boards
From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Date: Mon, 28 Jul 2008 10:08:42 +0300
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <1217002430.10968.30.camel@kh-ubuntu.razamicroelectronics.com>
Organization: Movial Creative Technologies
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1217002430.10968.30.camel@kh-ubuntu.razamicroelectronics.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Icedove 1.5.0.14eol (X11/20080509)
Kevin Hickey wrote:
> I found this when I updated to version 2.6.26.  None of my development
> boards would boot.  It appears that a previous update changed some calls
> to simple_strtol to strict_strtol but did not account for the different
> call semantics.

Hi Kevin,

1) you forgot to sign your patch off;
2) please consider using git to generate and submit patches. At least according 
to my experience, it's much more convenient than any other approach.
3) As I can see, the board-specific code is almost identical for the pb1x00 
boards. While at it, would you please try to merge it?

Regards,
Dmitri

> 
> Index: arch/mips/au1000/pb1000/init.c
> ===================================================================
> --- arch/mips/au1000/pb1000/init.c
> +++ arch/mips/au1000/pb1000/init.c
> @@ -52,6 +52,6 @@
>       if (!memsize_str)
>               memsize = 0x04000000;
>       else
> -             memsize = strict_strtol(memsize_str, 0, NULL);
> +             strict_strtol(memsize_str, 0, &memsize);
>       add_memory_region(0, memsize, BOOT_MEM_RAM);
>  }
> Index: arch/mips/au1000/pb1100/init.c
> ===================================================================
> --- arch/mips/au1000/pb1100/init.c
> +++ arch/mips/au1000/pb1100/init.c
> @@ -54,7 +54,7 @@
>       if (!memsize_str)
>               memsize = 0x04000000;
>       else
> -             memsize = strict_strtol(memsize_str, 0, NULL);
> +             strict_strtol(memsize_str, 0, &memsize);
>  
>       add_memory_region(0, memsize, BOOT_MEM_RAM);
>  }
> Index: arch/mips/au1000/pb1200/init.c
> ===================================================================
> --- arch/mips/au1000/pb1200/init.c
> +++ arch/mips/au1000/pb1200/init.c
> @@ -53,6 +53,6 @@
>       if (!memsize_str)
>               memsize = 0x08000000;
>       else
> -             memsize = strict_strtol(memsize_str, 0, NULL);
> +             strict_strtol(memsize_str, 0, &memsize);
>       add_memory_region(0, memsize, BOOT_MEM_RAM);
>  }
> Index: arch/mips/au1000/mtx-1/init.c
> ===================================================================
> --- arch/mips/au1000/mtx-1/init.c
> +++ arch/mips/au1000/mtx-1/init.c
> @@ -55,6 +55,6 @@
>       if (!memsize_str)
>               memsize = 0x04000000;
>       else
> -             memsize = strict_strtol(memsize_str, 0, NULL);
> +             strict_strtol(memsize_str, 0, &memsize);
>       add_memory_region(0, memsize, BOOT_MEM_RAM);
>  }
> Index: arch/mips/au1000/pb1500/init.c
> ===================================================================
> --- arch/mips/au1000/pb1500/init.c
> +++ arch/mips/au1000/pb1500/init.c
> @@ -53,6 +53,6 @@
>       if (!memsize_str)
>               memsize = 0x04000000;
>       else
> -             memsize = strict_strtol(memsize_str, 0, NULL);
> +             strict_strtol(memsize_str, 0, &memsize);
>       add_memory_region(0, memsize, BOOT_MEM_RAM);
>  }
> Index: arch/mips/au1000/xxs1500/init.c
> ===================================================================
> --- arch/mips/au1000/xxs1500/init.c
> +++ arch/mips/au1000/xxs1500/init.c
> @@ -53,6 +53,6 @@
>       if (!memsize_str)
>               memsize = 0x04000000;
>       else
> -             memsize = strict_strtol(memsize_str, 0, NULL);
> +             strict_strtol(memsize_str, 0, &memsize);
>       add_memory_region(0, memsize, BOOT_MEM_RAM);
>  }
> Index: arch/mips/au1000/pb1550/init.c
> ===================================================================
> --- arch/mips/au1000/pb1550/init.c
> +++ arch/mips/au1000/pb1550/init.c
> @@ -53,6 +53,6 @@
>       if (!memsize_str)
>               memsize = 0x08000000;
>       else
> -             memsize = strict_strtol(memsize_str, 0, NULL);
> +             strict_strtol(memsize_str, 0, &memsize);
>       add_memory_region(0, memsize, BOOT_MEM_RAM);
>  }
> Index: arch/mips/au1000/db1x00/init.c
> ===================================================================
> --- arch/mips/au1000/db1x00/init.c
> +++ arch/mips/au1000/db1x00/init.c
> @@ -57,6 +57,6 @@
>       if (!memsize_str)
>               memsize = 0x04000000;
>       else
> -             memsize = strict_strtol(memsize_str, 0, NULL);
> +             strict_strtol(memsize_str, 0, &memsize);
>       add_memory_region(0, memsize, BOOT_MEM_RAM);
>  }
> 


<Prev in Thread] Current Thread [Next in Thread>