linux-mips
[Top] [All Lists]

Re: [patch 29/29] initrd: Fix virtual/physical mix-up in overwrite test

To: geert@linux-m68k.org
Subject: Re: [patch 29/29] initrd: Fix virtual/physical mix-up in overwrite test
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sat, 26 Jul 2008 23:46:29 +0900 (JST)
Cc: ralf@linux-mips.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-arch@vger.kernel.org
In-reply-to: <Pine.LNX.4.64.0807252104460.11082@anakin>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64.0807242032430.701@anakin> <20080726.012731.122621958.anemo@mba.ocn.ne.jp> <Pine.LNX.4.64.0807252104460.11082@anakin>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 25 Jul 2008 21:22:20 +0200 (CEST), Geert Uytterhoeven 
<geert@linux-m68k.org> wrote:
> So there's definitely room for a small janitors project...
> 
> Probably the best short term solution is to make mips' virt_to_page()
> cast to `unsigned long' internally, like the other platforms.
>
> Alternatively, you can try the patch below (compile-tested on mips :-),
> which does add a cast to the generic code.

Thanks, I prefer this one for short term solution, while I think
explicit argument type would be better in general.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>