linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add severity levels to printk statements during kernel

To: Mike Crowe <mac@mcrowe.com>
Subject: Re: [PATCH] MIPS: Add severity levels to printk statements during kernel setup.
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sat, 26 Jul 2008 15:19:07 +0200 (CEST)
Cc: linux-mips@linux-mips.org
In-reply-to: <20080726125925.GB32426@mcrowe.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080725134454.GA26225@mcrowe.com> <Pine.LNX.4.64.0807252002490.11082@anakin> <20080726125925.GB32426@mcrowe.com>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 26 Jul 2008, Mike Crowe wrote:
> On Fri, 25 Jul 2008, I wrote:
> >> --- a/arch/mips/kernel/setup.c
> >> +++ b/arch/mips/kernel/setup.c
> >> @@ -78,7 +78,7 @@ void __init add_memory_region(phys_t start, phys_t size, 
> >> long type)
> >>  
> >>    /* Sanity check */
> >>    if (start + size < start) {
> >> -          printk("Trying to add an invalid memory region, skipped\n");
> >> +          printk(KERN_WARNING "Trying to add an invalid memory region, 
> >> skipped\n");
>  
> On Fri, Jul 25, 2008 at 08:04:57PM +0200, Geert Uytterhoeven wrote:
> > Why not convert to pr_warning(), while you're at it?
> 
> I can do. I'm just a bit behind the times. :-)
> 
> Should I use pr_{warning,err,info} everywhere rather than printk? Is

Yes, please.

> it worth fixing up the other calls to printk that I didn't need to
> "fix"?

If you have the time, you can do that. It also makes those (typically
too long) lines a bit shorter.

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>