linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add severity levels to printk statements during kernel

To: Mike Crowe <mac@mcrowe.com>
Subject: Re: [PATCH] MIPS: Add severity levels to printk statements during kernel setup.
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Fri, 25 Jul 2008 20:04:57 +0200 (CEST)
Cc: linux-mips@linux-mips.org
In-reply-to: <20080725134454.GA26225@mcrowe.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080725134454.GA26225@mcrowe.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 25 Jul 2008, Mike Crowe wrote:
> Signed-off-by: Mike Crowe <mac@mcrowe.com>
> ---
>  arch/mips/kernel/setup.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index 8af8486..fcb12b9 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -78,7 +78,7 @@ void __init add_memory_region(phys_t start, phys_t size, 
> long type)
>  
>       /* Sanity check */
>       if (start + size < start) {
> -             printk("Trying to add an invalid memory region, skipped\n");
> +             printk(KERN_WARNING "Trying to add an invalid memory region, 
> skipped\n");

Why not convert to pr_warning(), while you're at it?

> @@ -221,7 +221,7 @@ static void __init finalize_initrd(void)
>               goto disable;
>       }
>       if (__pa(initrd_end) > PFN_PHYS(max_low_pfn)) {
> -             printk("Initrd extends beyond end of memory");
> +             printk(KERN_ERR "Initrd extends beyond end of memory");
                                                                    ^
There's no newline here, so...

>               goto disable;
>       }
>  
> @@ -232,7 +232,7 @@ static void __init finalize_initrd(void)
>              initrd_start, size);
>       return;
>  disable:
> -     printk(" - disabling initrd\n");
> +     printk(KERN_ERR " - disabling initrd\n");
               ^^^^^^^^
... probably this should be KERN_CONT.
Note that I didn't check the other paths to get here.

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>