linux-mips
[Top] [All Lists]

[PATCH 1/1] Char: ds1286, eliminate busy waiting

To: Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 1/1] Char: ds1286, eliminate busy waiting
From: Jiri Slaby <jirislaby@gmail.com>
Date: Fri, 25 Jul 2008 19:49:58 +0200
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>, Ralf Baechle <ralf@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
ds1286_get_time(); is not called from atomic context, sleep for 20 ms is
better choice than a (home-made) busy waiting for such a situation.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
 drivers/char/ds1286.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ds1286.c b/drivers/char/ds1286.c
index fb58493..5329d48 100644
--- a/drivers/char/ds1286.c
+++ b/drivers/char/ds1286.c
@@ -443,7 +443,6 @@ static void ds1286_get_time(struct rtc_time *rtc_tm)
 {
        unsigned char save_control;
        unsigned long flags;
-       unsigned long uip_watchdog = jiffies;
 
        /*
         * read RTC once any update in progress is done. The update
@@ -456,8 +455,7 @@ static void ds1286_get_time(struct rtc_time *rtc_tm)
         */
 
        if (ds1286_is_updating() != 0)
-               while (time_before(jiffies, uip_watchdog + 2*HZ/100))
-                       barrier();
+               msleep(20);
 
        /*
         * Only the values that we read from the RTC are set. We leave
-- 
1.5.6.2


<Prev in Thread] Current Thread [Next in Thread>