linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core
From: Jason Wessel <jason.wessel@windriver.com>
Date: Fri, 18 Jul 2008 12:50:08 -0500
Cc: linux-kernel@vger.kernel.org, ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20080719.023116.122828931.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1216400928-29097-1-git-send-email-jason.wessel@windriver.com><1216400928-29097-2-git-send-email-jason.wessel@windriver.com><1216400928-29097-3-git-send-email-jason.wessel@windriver.com> <20080719.023116.122828931.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.14 (X11/20080502)
Atsushi Nemoto wrote:
> 
> The kgdb_ealy_setup check should be at beginning of init_IRQ (before
> set_irq_noprobe loop)?


I would agree, and it looks like the following now in the patch.
I will revalidate with the HW to ensure there is no regression. :-)

Jason.

@@ -130,8 +135,18 @@ void __init init_IRQ(void)
 {
        int i;
 
+#ifdef CONFIG_KGDB
+       if (kgdb_early_setup)
+               return;
+#endif
+
        for (i = 0; i < NR_IRQS; i++)
                set_irq_noprobe(i);
 
        arch_init_irq();
+
+#ifdef CONFIG_KGDB
+       if (!kgdb_early_setup)
+               kgdb_early_setup = 1;
+#endif
 }

<Prev in Thread] Current Thread [Next in Thread>