linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core

To: jason.wessel@windriver.com
Subject: Re: [PATCH 2/3] kgdb, mips: add arch support for the kernel's kgdb core
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sat, 19 Jul 2008 02:31:16 +0900 (JST)
Cc: linux-kernel@vger.kernel.org, ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <1216400928-29097-3-git-send-email-jason.wessel@windriver.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1216400928-29097-1-git-send-email-jason.wessel@windriver.com> <1216400928-29097-2-git-send-email-jason.wessel@windriver.com> <1216400928-29097-3-git-send-email-jason.wessel@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 18 Jul 2008 12:08:47 -0500, Jason Wessel <jason.wessel@windriver.com> 
wrote:
> The new kgdb architecture specific handler registers and unregisters
> dynamically for exceptions depending on when you configure a kgdb I/O
> driver.  Asside from initializing the exceptions earlier in the boot
> process, kgdb should have no impact on a device when it is compiled in
> so long as an I/O module is not configured for use.
...
> @@ -133,5 +138,15 @@ void __init init_IRQ(void)
>       for (i = 0; i < NR_IRQS; i++)
>               set_irq_noprobe(i);
>  
> +#ifdef CONFIG_KGDB
> +     if (kgdb_early_setup)
> +             return;
> +#endif
> +
>       arch_init_irq();
> +
> +#ifdef CONFIG_KGDB
> +     if (!kgdb_early_setup)
> +             kgdb_early_setup = 1;
> +#endif
>  }

The kgdb_ealy_setup check should be at beginning of init_IRQ (before
set_irq_noprobe loop)?

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>