linux-mips
[Top] [All Lists]

Re: [PATCH][MIPS] mips_machtype define as one group

To: yoichi_yuasa@tripeaks.co.jp
Subject: Re: [PATCH][MIPS] mips_machtype define as one group
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Sun, 13 Jul 2008 22:13:03 +0900 (JST)
Cc: tsbogend@alpha.franken.de, ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20080713194503.23e4e1a1.yoichi_yuasa@tripeaks.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080712174741.c4dd3149.yoichi_yuasa@tripeaks.co.jp> <20080712143225.GA9053@alpha.franken.de> <20080713194503.23e4e1a1.yoichi_yuasa@tripeaks.co.jp>
Sender: linux-mips-bounce@linux-mips.org
On Sun, 13 Jul 2008 19:45:03 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> 
wrote:
> > this looks a little messy. The _EVAL and _GW defines are more a kernel
> > config option than a real machine type and all they are good for is
> > selecting whether there is a second serial port and which speed the
> > speed kgdb should use. I'd remove that all and just set a flag, whether
> > there is a second uart. I'd remove the kgbd usage, but if it's really
> > needed adding another flag/variabne would do the trick.
> > 
> > Anything I missed ?
> 
> I totally agree with you.
> I'm making a patch for MACH_TOSHIBA_* .

Thanks, I'll review your patchset soon.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>