Re: [PATCH][MIPS] mips_machtype define as one group

[Atsushi Nemoto <anemo@mba.ocn.ne.jp>]

On Sun, 13 Jul 2008 19:45:03 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> 
wrote:
> > this looks a little messy. The _EVAL and _GW defines are more a kernel
> > config option than a real machine type and all they are good for is
> > selecting whether there is a second serial port and which speed the
> > speed kgdb should use. I'd remove that all and just set a flag, whether
> > there is a second uart. I'd remove the kgbd usage, but if it's really
> > needed adding another flag/variabne would do the trick.
> > 
> > Anything I missed ?
> 
> I totally agree with you.
> I'm making a patch for MACH_TOSHIBA_* .

Thanks, I'll review your patchset soon.

---
Atsushi Nemoto