linux-mips
[Top] [All Lists]

Re: [PATCH] sparse: Increase pre_buffer[] and check overflow

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] sparse: Increase pre_buffer[] and check overflow
From: Sam Ravnborg <sam@ravnborg.org>
Date: Wed, 9 Jul 2008 18:32:12 +0200
Cc: linux-sparse@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20080710.011818.26096759.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080709.002805.128619748.anemo@mba.ocn.ne.jp> <20080708204547.GA16742@uranus.ravnborg.org> <20080710.011818.26096759.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Thu, Jul 10, 2008 at 01:18:18AM +0900, Atsushi Nemoto wrote:
> On Tue, 8 Jul 2008 22:45:47 +0200, Sam Ravnborg <sam@ravnborg.org> wrote:
> > > The linus-mips kernel uses '$(CC) -dM -E' to generates arguments for
> > > sparse.  With gcc 4.3, it generates lot of '-D' options and causes
> > > pre_buffer overflow.
> > 
> > Why does mips have this need when all other archs does not?
> > We should fix sparse so it is dynamically allocated - but
> > that is not an excuse for mips to use odd stuff like this.
> > 
> > So please someone from mips land explain why this is needed.
> 
> This was introduced by commit 59b3e8e9aac69d2d02853acac7e2affdfbabca50.
> ("[MIPS] Makefile crapectomy.")
> 
> Before the commit, CHECKFLAGS was adjusted like this:
> 
> CHECKFLAGS-y                          += -D__linux__ -D__mips__ \
>                                          -D_MIPS_SZINT=32 \
>                                          -D_ABIO32=1 \
...

So the expalnation seems that gcc for mips define much more
than the usual gcc does.
My gcc define 76 symbols for i386.

And we use this stuff in the kernel.

OK - thanks for the details.

        Sam

<Prev in Thread] Current Thread [Next in Thread>