linux-mips
[Top] [All Lists]

Re: [PATCH] sparse: Increase pre_buffer[] and check overflow

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] sparse: Increase pre_buffer[] and check overflow
From: Sam Ravnborg <sam@ravnborg.org>
Date: Tue, 8 Jul 2008 22:45:47 +0200
Cc: linux-sparse@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20080709.002805.128619748.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080709.002805.128619748.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.2.1i
On Wed, Jul 09, 2008 at 12:28:05AM +0900, Atsushi Nemoto wrote:
> I got this error when running sparse on mips kernel with gcc 4.3:
> 
> builtin:272:1: warning: Newline in string or character constant
> 
> The linus-mips kernel uses '$(CC) -dM -E' to generates arguments for
> sparse.  With gcc 4.3, it generates lot of '-D' options and causes
> pre_buffer overflow.

Why does mips have this need when all other archs does not?
We should fix sparse so it is dynamically allocated - but
that is not an excuse for mips to use odd stuff like this.

So please someone from mips land explain why this is needed.

        Sam

<Prev in Thread] Current Thread [Next in Thread>