linux-mips
[Top] [All Lists]

Re: [PATCH 5/5] [MIPS] Add an appropriate header into display.c

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 5/5] [MIPS] Add an appropriate header into display.c
From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Date: Thu, 03 Jul 2008 18:28:31 +0300
Cc: linux-mips@linux-mips.org
In-reply-to: <20080703152338.GC11434@linux-mips.org>
Organization: Movial Creative Technologies
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1213773503-23536-1-git-send-email-dmitri.vorobiev@movial.fi> <1213773503-23536-6-git-send-email-dmitri.vorobiev@movial.fi> <20080703152338.GC11434@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Icedove 1.5.0.14eol (X11/20080509)
Ralf Baechle wrote:
> On Wed, Jun 18, 2008 at 10:18:23AM +0300, Dmitri Vorobiev wrote:
> 
>> The following errors were caught by sparse:
>>
>> arch/mips/mips-boards/generic/display.c:30:6: warning: symbol
>> 'mips_display_message' was not declared. Should it be static?
>>
>> arch/mips/mips-boards/generic/display.c:58:6: warning: symbol
>> 'mips_scroll_message' was not declared. Should it be static?
>>
>> This patch includes the asm/mips-boards/prom.h header file into
>> arch/mips/mips-boards/generic/display.c. This adds the needed
>> function declarations, and the errors are gone.
>>
>> Compile-tested using defconfigs for Malta, Atlas and SEAD boards.
>> Runtime test was successfully performed by booting a Malta 4Kc
>> board up to the shell prompt.
>>
>> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
> 
> Queued for 2.6.27.  Thanks,

Ralf, thanks for picking up the series.

Dmitri

<Prev in Thread] Current Thread [Next in Thread>