linux-mips
[Top] [All Lists]

Re: [PATCH 3/5] [MIPS] A few cleanups in malta_int.c

To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Subject: Re: [PATCH 3/5] [MIPS] A few cleanups in malta_int.c
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 3 Jul 2008 16:22:45 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <1213773503-23536-4-git-send-email-dmitri.vorobiev@movial.fi>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1213773503-23536-1-git-send-email-dmitri.vorobiev@movial.fi> <1213773503-23536-4-git-send-email-dmitri.vorobiev@movial.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Jun 18, 2008 at 10:18:21AM +0300, Dmitri Vorobiev wrote:

> Both the fill_ipi_map() routine and the gic_intr_map array defined
> in arch/mips/mips-boards/malta/malta_int.c are not used outside of
> the latter file. Thus, these objects can become static. Moreover,
> these two objects are used by the MT code only, which is why this
> patch adds the appropriate ifdef.
> 
> While at it, this patch removes an unnecessary preprocessing macro
> in favor of the commonly used ARRAY_SIZE.
> 
> Successfully tested using a Qemu-emulated Malta board for both SMP
> and UP kernels.
> 
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>

Queued for 2.6.27 after fixing a reject.  Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 3/5] [MIPS] A few cleanups in malta_int.c, Ralf Baechle <=