| To: | Thomas Bogendoerfer <tsbogend@alpha.franken.de> |
|---|---|
| Subject: | Re: [PATCH] IP22: Fix crashes due to wrong L1_CACHE_BYTES |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Sat, 28 Jun 2008 20:25:09 +0200 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <20080627215226.D1B5EE2F71@solo.franken.de> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20080627215226.D1B5EE2F71@solo.franken.de> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Fri, Jun 27, 2008 at 11:52:26PM +0200, Thomas Bogendoerfer wrote: > The introduction of a real dma cache invalidate makes it important > to have a correct cache line size, otherwise the kernel will gives > out two memory segment, which might share one cache line. The R4400 > Indy/Indigo2 CPU modules are using a second level cache line size > of 128 bytes, so MIPS_L1_CACHE_SHIFT needs to be bumped up to 7 for > IP22. Thanks, applied. I also think this missconfiguration is worth an additional runtime check; the consequence of that kind of bug are subtle and painful to debug. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RFC: Adding non-PIC executable support to MIPS, Richard Sandiford |
|---|---|
| Next by Date: | Re: [PATCH] cevt-txx9: Reset timer counter on initialize, Ralf Baechle |
| Previous by Thread: | [PATCH] IP22: Fix crashes due to wrong L1_CACHE_BYTES, Thomas Bogendoerfer |
| Next by Thread: | SGI O2 sound driver, Thomas Bogendoerfer |
| Indexes: | [Date] [Thread] [Top] [All Lists] |