linux-mips
[Top] [All Lists]

Re: [PATCH] tc35815: Mark carrier-off before starting PHY

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] tc35815: Mark carrier-off before starting PHY
From: Jeff Garzik <jeff@garzik.org>
Date: Fri, 27 Jun 2008 01:34:03 -0400
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <20080625.114101.102912128.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080625.114101.102912128.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.14 (X11/20080501)
Atsushi Nemoto wrote:
Call netif_carrier_off() before starting PHY device.  This is a
behavior before converting to generic PHY layer.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
index 10e4e85..dccea52 100644
--- a/drivers/net/tc35815.c
+++ b/drivers/net/tc35815.c
@@ -1394,6 +1394,7 @@ tc35815_open(struct net_device *dev)
        tc35815_chip_init(dev);
        spin_unlock_irq(&lp->lock);
+ netif_carrier_off(dev);
        /* schedule a link state check */
        phy_start(lp->phy_dev);
@@ -2453,6 +2454,7 @@ static int tc35815_resume(struct pci_dev *pdev)
                return 0;
        pci_set_power_state(pdev, PCI_D0);
        tc35815_restart(dev);
+       netif_carrier_off(dev);
        if (lp->phy_dev)

applied



<Prev in Thread] Current Thread [Next in Thread>