| To: | linux-mips@linux-mips.org |
|---|---|
| Subject: | [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow |
| From: | Atsushi Nemoto <anemo@mba.ocn.ne.jp> |
| Date: | Thu, 26 Jun 2008 17:14:15 +0900 (JST) |
| Cc: | Jeff Garzik <jeff@garzik.org>, netdev@vger.kernel.org |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| Sender: | linux-mips-bounce@linux-mips.org |
On Rx FIFO overflow error, the controller consume a buffer descriptor
but currently the driver does not give it back to the controller.
This results unrecoverable 'Buffer List Exhausted' condition. This
patch fix this problem by moving a "fbl_count--" line to proper place.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
index dccea52..b07b8cb 100644
--- a/drivers/net/tc35815.c
+++ b/drivers/net/tc35815.c
@@ -1736,7 +1736,6 @@ tc35815_rx(struct net_device *dev)
skb = lp->rx_skbs[cur_bd].skb;
prefetch(skb->data);
lp->rx_skbs[cur_bd].skb = NULL;
- lp->fbl_count--;
pci_unmap_single(lp->pci_dev,
lp->rx_skbs[cur_bd].skb_dma,
RX_BUF_SIZE, PCI_DMA_FROMDEVICE);
@@ -1792,6 +1791,7 @@ tc35815_rx(struct net_device *dev)
#ifdef TC35815_USE_PACKEDBUFFER
while (lp->fbl_curid != id)
#else
+ lp->fbl_count--;
while (lp->fbl_count < RX_BUF_NUM)
#endif
{
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Fix IP32 unexpected irq 71, Ralf Baechle |
|---|---|
| Next by Date: | Re: Bug in atomic_sub_if_positive, Ralf Baechle |
| Previous by Thread: | Bug in atomic_sub_if_positive, Morten Larsen |
| Next by Thread: | Re: [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |