linux-mips
[Top] [All Lists]

[PATCH] [MIPS] change EARLY_PRINTK default to n

To: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] [MIPS] change EARLY_PRINTK default to n
From: David Pelton <david.r.pelton@gmail.com>
Date: Mon, 16 Jun 2008 15:15:39 -0400
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=7QWnZj3xf/+rXajrxxKwiskWmIMkeUNaH0NdvoATygc=; b=K/f1eU0U9GJlAj/CvUp+xZmBKn5Q0MAvn5EEmTQQqgXcjtiDQ7Uy7HnFOciVuYnJFF 9HvxTcqE/WiApEhnJTA4PpVetbjz8fyXvhZNLPOvZLF1eidkKpxxLuXbeO4x8jSKXW+T MKtwcFVcvcIJmILZv03szCvHoUB1+5t8jo+KE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=ly3jSxdq9E91ht/EWmsCEZYuimraVCJ0UttAc51vXvPBUyKmu2pSC604l+L24YsFqP 6SPfZuKydxZCh6tQ2TTPHNEDcP2a9701zX03xMD2axQrvNTzt0dg/QnBd5puoR0Zh4ch drtvcI1uQZSPyZ8y+CsCRwVRTKf4qZFHt87vU=
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.14 (Windows/20080421)

This patch changes the default for CONFIG_EARLY_PRINTK to n.  Prior to
this change, the presence of SYS_HAS_EARLY_PRINTK would always set
EARLY_PRINTK to y if either EMBEDDED or DEBUG_KERNEL were not set.  As
this is a debugging option, it should default to n.

Signed-off-by: David Pelton <david.r.pelton@gmail.com>
---

Hi,

while fiddling with kernel configuration options for the Broadcom eval
board I am working with, I noticed that turning off DEBUG_KERNEL would
make many bad things happen.  I did not get to the root cause, but I
think that some of the early printk drivers have some dependency on
functionality enabled by DEBUG_KERNEL.  The 2.6.25.6 kernel has a
default value of "y" for EARLY_PRINTK, and this default will be applied
anytime the platform claims to support early printk.  In particular, if
DEBUG_KERNEL is not selected, there is no way to disable EARLY_PRINTK.
This patch changes the default to "n" to avoid these problems.

- David Pelton


arch/mips/Kconfig |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


diff -Nraup linux-2.6.25.6-clean/arch/mips/Kconfig 
linux-2.6.25.6/arch/mips/Kconfig
--- linux-2.6.25.6-clean/arch/mips/Kconfig      2008-06-09 14:27:19.000000000 
-0400
+++ linux-2.6.25.6/arch/mips/Kconfig    2008-06-16 14:34:33.229160000 -0400
@@ -807,7 +807,7 @@ config DMA_NEED_PCI_MAP_STATE
config EARLY_PRINTK
       bool "Early printk" if EMBEDDED && DEBUG_KERNEL
       depends on SYS_HAS_EARLY_PRINTK
-       default y
+       default n
       help
         This option enables special console drivers which allow the kernel
         to print messages very early in the bootup process.


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] [MIPS] change EARLY_PRINTK default to n, David Pelton <=