On Tue, Jun 03, 2008 at 12:12:40PM +0300, Dmitri Vorobiev wrote:
> From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
> Date: Tue, 3 Jun 2008 12:12:40 +0300
> To: linux-mips@linux-mips.org, ralf@linux-mips.org
> Subject: [PATCH 1/5] [MIPS] fix sparse warning about setup_early_printk()
>
> This patch fixes the following sparse warning:
>
> <<<<<<<<
>
> arch/mips/kernel/early_printk.c:35:13: warning: symbol 'setup_early_printk'
> was not declared. Should it be static?
>
> <<<<<<<<
>
> The fix is to define a prototype of the setup_early_printk() function and
> to include the appropriate header into arch/mips/kernel/early_printk.c.
>
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
> ---
> arch/mips/kernel/early_printk.c | 1 +
> arch/mips/kernel/setup.c | 6 +-----
> include/asm-mips/setup.h | 2 ++
> 3 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/arch/mips/kernel/early_printk.c b/arch/mips/kernel/early_printk.c
> index 9dccfa4..cb602c1 100644
> --- a/arch/mips/kernel/early_printk.c
> +++ b/arch/mips/kernel/early_printk.c
> @@ -7,6 +7,7 @@
> * Copyright (C) 2007 MIPS Technologies, Inc.
> * written by Ralf Baechle (ralf@linux-mips.org)
> */
> +#include <asm/setup.h>
> #include <linux/console.h>
> #include <linux/init.h>
Queued for 2.6.27 with includes sorted <linux/...> first followed by
<asm/...>.
Ralf
|