linux-mips
[Top] [All Lists]

Re: [PATCH 5/5] [MIPS] The tickcount per-cpu variable can become static

To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Subject: Re: [PATCH 5/5] [MIPS] The tickcount per-cpu variable can become static
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 11 Jun 2008 18:44:15 +0100
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <12120730321843-git-send-email-dmitri.vorobiev@movial.fi>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <12120730323761-git-send-email-dmitri.vorobiev@movial.fi> <12120730321843-git-send-email-dmitri.vorobiev@movial.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, May 29, 2008 at 05:57:12PM +0300, Dmitri Vorobiev wrote:

> In arch/mips/mips-boards/generic/time.c, the `tickcount' per-cpu
> variable is needlessly defined global, and this patch makes it
> static.
> 
> Noticed by sparse. Tested by booting a Qemu-emulated Malta board
> up to the shell prompt.

Patch is ok - except it tries to fix a piece of code which I've already
removed so I'll drop this one.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 5/5] [MIPS] The tickcount per-cpu variable can become static, Ralf Baechle <=