linux-mips
[Top] [All Lists]

Re: [PATCH 8/9] au1xmmc: abort requests early if no card is present

To: Pierre Ossman <drzeus@drzeus.cx>
Subject: Re: [PATCH 8/9] au1xmmc: abort requests early if no card is present
From: Manuel Lauss <mano@roarinelk.homelinux.net>
Date: Fri, 6 Jun 2008 09:17:29 +0200
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, sshtylyov@ru.mvista.com
In-reply-to: <20080605230552.68c14b2d@mjolnir.drzeus.cx>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080519080339.GA21985@roarinelk.homelinux.net> <20080519080804.GI21985@roarinelk.homelinux.net> <20080605230552.68c14b2d@mjolnir.drzeus.cx>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.16 (2007-06-09)
Hi Pierre,

On Thu, Jun 05, 2008 at 11:05:52PM +0200, Pierre Ossman wrote:
> On Mon, 19 May 2008 10:08:04 +0200
> Manuel Lauss <mano@roarinelk.homelinux.net> wrote:
> 
> > From ec41439903048bf98e301dbd03426c63156ebc0e Mon Sep 17 00:00:00 2001
> > From: Manuel Lauss <mlau@msc-ge.com>
> > Date: Sun, 18 May 2008 15:52:43 +0200
> > Subject: [PATCH] au1xmmc: abort requests early if no card is present
> > 
> > Don't process a request if no card is present.
> > 
> > Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>
> > ---
> >  drivers/mmc/host/au1xmmc.c |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c
> > index be09a14..0b30582 100644
> > --- a/drivers/mmc/host/au1xmmc.c
> > +++ b/drivers/mmc/host/au1xmmc.c
> > @@ -689,6 +689,13 @@ static void au1xmmc_request(struct mmc_host *mmc, 
> > struct mmc_request *mrq)
> >     host->mrq = mrq;
> >     host->status = HOST_S_CMD;
> >  
> > +   /* fail request immediately if no card is present */
> > +   if (0 == au1xmmc_card_inserted(host)) {
> > +           mrq->cmd->error = -ETIMEDOUT;
> > +           au1xmmc_finish_request(host);
> > +           return;
> > +   }
> > +
> >     if (mrq->data) {
> >             FLUSH_FIFO(host);
> >             ret = au1xmmc_prepare_data(host, mrq->data);
> 
> You should use -ENOMEDIUM for this case.

Didn't know it existed, consider it changed.

Thanks!
        Manuel Lauss


<Prev in Thread] Current Thread [Next in Thread>