linux-mips
[Top] [All Lists]

Re: ext4dev build failure on mips: "empty_zero_page" undefined

To: Martin Michlmayr <tbm@cyrius.com>
Subject: Re: ext4dev build failure on mips: "empty_zero_page" undefined
From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Date: Thu, 05 Jun 2008 14:22:57 +0300
Cc: Ralf Baechle <ralf@linux-mips.org>, Dmitri Vorobiev <dmitri.vorobiev@gmail.com>, Theodore Tso <tytso@mit.edu>, linux-mips@linux-mips.org, linux-ext4@vger.kernel.org
In-reply-to: <20080605111148.GA4483@deprecation.cyrius.com>
Organization: Movial Creative Technologies
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080512130604.GA15008@deprecation.cyrius.com> <90edad820805120654n50f7a00cm3c7b4a4f9346d5ea@mail.gmail.com> <20080512143426.GB7029@mit.edu> <90edad820805120746l61e67362vbd177d63e8b05dc8@mail.gmail.com> <20080513045028.GC22226@linux-mips.org> <20080528070637.GA10393@deprecation.cyrius.com> <20080605111148.GA4483@deprecation.cyrius.com>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 2008-06-05 at 13:11 +0200, Martin Michlmayr wrote:
> * Martin Michlmayr <tbm@cyrius.com> [2008-05-28 09:06]:
> > * Ralf Baechle <ralf@linux-mips.org> [2008-05-13 05:50]:
> > > I prefer to do it myself so I can apply it at the same time to the MIPS
> > > -stable branches.
> > > 
> > > I'm a little irriated that this thread seems to be only about
> > > empty_zero_page but apparently not zero_page_mask?  empty_zero_page is
> > > actualy an array of pages on MIPS and ZERO_PAGE() will pick the right one
> > > for a particular user space mapping based on the virtual address but
> > > ZERO_PAGE() also references zero_page_mask.  So I sense more brokenness
> > > here.
> > 
> > Just as a reminder, this issue is still there (at least with rc4).
> 
> Still present in rc5.

It looks like the discussion related to this issue has faded out. Ralf
seemed to have some objections to using ZERO_PAGE() outside of the
context of getting a user-mapped page, but I think that ext4 driver is
still doing that.

Ralf, will it be possible to use the patch I sent earlier as a temporary
solution? Just to make sure the kernel builds?

Thanks,
Dmitri
> 


<Prev in Thread] Current Thread [Next in Thread>