linux-mips
[Top] [All Lists]

Re: [2.6 patch] MIPS SEAD compile fix

To: Adrian Bunk <adrian.bunk@movial.fi>
Subject: Re: [2.6 patch] MIPS SEAD compile fix
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 26 May 2008 23:43:42 +0100
Cc: Chris Dearman <chris@mips.com>, Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <20080525180316.GF1791@cs181133002.pp.htv.fi>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080525180316.GF1791@cs181133002.pp.htv.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Sun, May 25, 2008 at 09:03:16PM +0300, Adrian Bunk wrote:

> This patch fixes the following compile error caused by
> commit 39b8d5254246ac56342b72f812255c8f7a74dca9
> ([MIPS] Add support for MIPS CMP platform.):
> 
> <--  snip  -->
> 
> ...
>   CC      arch/mips/mips-boards/generic/time.o
> cc1: warnings being treated as errors
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/mips-boards/generic/time.c:63:
>  error: 'ledbitmask' defined but not used
> make[2]: *** [arch/mips/mips-boards/generic/time.o] Error 1
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
> 
> ---
> a6622e47dd128da338d6dbae457ec1b043604814 diff --git 
> a/arch/mips/mips-boards/generic/time.c b/arch/mips/mips-boards/generic/time.c
> index 008fd82..df23558 100644
> --- a/arch/mips/mips-boards/generic/time.c
> +++ b/arch/mips/mips-boards/generic/time.c

[...]

> +#if defined(CONFIG_MIPS_MALTA) || defined(CONFIG_MIPS_ATLAS)

Generic code thanks to #ifdef ;-)  Not really the way to go.  I just blew
away the original offending change.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>