linux-mips
[Top] [All Lists]

Re: [PATCH] RTC: M41T80: Century Bit support

To: macro@linux-mips.org
Subject: Re: [PATCH] RTC: M41T80: Century Bit support
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Date: Mon, 19 May 2008 01:10:34 +0900 (JST)
Cc: a.zummo@towertech.it, hvr@gnu.org, akpm@linux-foundation.org, rtc-linux@googlegroups.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <Pine.LNX.4.55.0805171959030.10067@cliff.in.clinika.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.55.0805170057370.4049@cliff.in.clinika.pl> <20080518.000242.41199304.anemo@mba.ocn.ne.jp> <Pine.LNX.4.55.0805171959030.10067@cliff.in.clinika.pl>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 17 May 2008 20:16:20 +0100 (BST), "Maciej W. Rozycki" 
<macro@linux-mips.org> wrote:
> > How about doing like this?
> > 
> > 1. If CEB was 0, keep current behavior. (does not touch CB bit)
> > 
> > 2. If CEB was 1, detect polarity of CB bit on get_datetime, and set or
> >    clear CB bit on set_datetime based on the polarity.
> 
>  That's what I did initially as it is as obvious as you can get.  But as I
> noted, CFE, the firmware used with the SWARM, does not set CEB even though
> it takes CB into account.  The approach is not useful therefore at least
> for one major user of the device.

Oh I had missed that the firmware does not set CEB.  Hmm...

>  Of course CFE is BSD-licensed and can be changed too, but based on my
> experience with how serious bugs are handled, I would not count on getting
> such a minor change integrated into the official sources.
> 
> > Please look at "c_polarity" variable in rtc-pcf8563.c driver.
> 
>  Hmm, not terribly useful as few of us if anybody live back in the 20th
> century. ;-)  I think let's scrap the patch in this case and let our
> grandchildren solve the problem -- a proposal has been published and can
> be reused as needed.

OK for me.  Lets hear how our grandchildren complain on this fault. :)

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>