linux-mips
[Top] [All Lists]

Re: [PATCH RESEND] [MIPS]: multi-statement if() seems to be missing brac

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH RESEND] [MIPS]: multi-statement if() seems to be missing braces
From: Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 13 May 2008 18:02:25 -0700
Cc: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>, linux-mips@linux-mips.org
In-reply-to: <20080513232507.GA24102@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.64.0805131444360.15369@wrl-59.cs.helsinki.fi> <20080513232507.GA24102@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 14 May 2008 00:25:07 +0100 Ralf Baechle <ralf@linux-mips.org> wrote:

> On Tue, May 13, 2008 at 02:50:50PM +0300, Ilpo J__rvinen wrote:
> 
> > In case this is a genuine bug, somebody else more familiar
> > with that stuff should evaluate it's effects (I just found it
> > by some shell pipeline and it seems suspicious looking).
> 
> Should be fairly as proven by practice; it's there since day of of 64-bit
> pagetable for 32-bit hw support which was November 29, 2004.
> 

It's unlikely that anyone would notice an error in pte_mkyoung().  It
will affect page reclaim behaviour and _might_ be demonstrable with a
carefully set up test.  But an error in here won't cause crashes or
lockups or anything.

What this needs is someone who understands the architecture (ie: you
;)) to take a look, please.


<Prev in Thread] Current Thread [Next in Thread>