linux-mips
[Top] [All Lists]

[PATCH RESEND] [MIPS]: multi-statement if() seems to be missing braces

To: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH RESEND] [MIPS]: multi-statement if() seems to be missing braces
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Tue, 13 May 2008 14:50:50 +0300 (EEST)
Cc: linux-mips@linux-mips.org, Andrew Morton <akpm@linux-foundation.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
In case this is a genuine bug, somebody else more familiar
with that stuff should evaluate it's effects (I just found it
by some shell pipeline and it seems suspicious looking).

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---

...Added Cc Andrew as I didn't get any response last time.

 include/asm-mips/pgtable.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/asm-mips/pgtable.h b/include/asm-mips/pgtable.h
index 2f597ee..6a0edf7 100644
--- a/include/asm-mips/pgtable.h
+++ b/include/asm-mips/pgtable.h
@@ -239,9 +239,10 @@ static inline pte_t pte_mkdirty(pte_t pte)
 static inline pte_t pte_mkyoung(pte_t pte)
 {
        pte.pte_low |= _PAGE_ACCESSED;
-       if (pte.pte_low & _PAGE_READ)
+       if (pte.pte_low & _PAGE_READ) {
                pte.pte_low  |= _PAGE_SILENT_READ;
                pte.pte_high |= _PAGE_SILENT_READ;
+       }
        return pte;
 }
 #else
-- 
1.5.2.2
<Prev in Thread] Current Thread [Next in Thread>