linux-mips
[Top] [All Lists]

Re: [RFC] [PATCH 1/1] [MIPS] Advanced Kernel Stack Backtrace

To: "Ralf Baechle [ralf"@linux-mips.org]
Subject: Re: [RFC] [PATCH 1/1] [MIPS] Advanced Kernel Stack Backtrace
From: David VomLehn <dvomlehn@cisco.com>
Date: Mon, 12 May 2008 10:14:20 -0700
Authentication-results: sj-dkim-4; header.From=dvomlehn@cisco.com; dkim=pass ( sig from cisco.com/sjdkim4002 verified; );
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; l=549; t=1210612475; x=1211476475; c=relaxed/simple; s=sjdkim4002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=dvomlehn@cisco.com; z=From:=20David=20VomLehn=20<dvomlehn@cisco.com> |Subject:=20Re=3A=20[RFC]=20[PATCH=201/1]=20[MIPS]=20Advanc ed=20Kernel=20Stack=20Backtrace |Sender:=20; bh=8OiEY+e8tXIW4lt0qnwUg2gK9fVczFbQ8M26giiSO9Y=; b=fJmG+y3nMRPkoNPb81wFk9u+LXakFjcrn4rGXvaxKNj+8IJyqmbhr4M5k1 wxD3qQGdPNRn12ftiDWIlJAM97QxEsuDz9EGAzhJJpdET8LFXc70Vi6HAeLb fT+ErOHp7L;
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.14 (Windows/20080421)
On Wed, May 07, 2008 at 04:49:53PM -0700, David VomLehn wrote:

This patch contains the kernel stack backtrace code we've been running for about a year on our MIPS-based settop box. ...

 o Use ARRAY_SIZE() from <linux/kernel.h> instead of numberof.

Oops, missed this one in the port from 2.6.14 to 2.6.24.

 o Please run the patch through scripts/checkpatch.pl and fix the resulting
   errors.

Will do.

 o Your patch got linewrapped by your mail client.

Ouch. I'll fix that next time.

  Ralf

Thanks!



<Prev in Thread] Current Thread [Next in Thread>