linux-mips
[Top] [All Lists]

Re: [PATCH] Fix check for valid stack pointer during backtrace

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH] Fix check for valid stack pointer during backtrace
From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
Date: Mon, 12 May 2008 17:56:35 +0200
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20080512.232421.108306312.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080512125923.0C641DE534@solo.franken.de> <20080512.232421.108306312.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
On Mon, May 12, 2008 at 11:24:21PM +0900, Atsushi Nemoto wrote:
> > -   unsigned long *sp = (unsigned long *)(reg29 & ~3);
> > +   unsigned long __user *sp = (unsigned long __user *)(reg29 & ~3);
> 
> Please drop this change, while kstack_end expect non __user pointer.

arg, of course. Thanks.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

<Prev in Thread] Current Thread [Next in Thread>