linux-mips
[Top] [All Lists]

Re: [RFC][PATCH 4/4] RTC: SMBus support for the M41T80, etc. driver

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [RFC][PATCH 4/4] RTC: SMBus support for the M41T80, etc. driver
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Fri, 9 May 2008 01:17:21 +0100 (BST)
Cc: a.zummo@towertech.it, khali@linux-fr.org, ralf@linux-mips.org, tglx@linutronix.de, akpm@linux-foundation.org, rtc-linux@googlegroups.com, i2c@lm-sensors.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, ab@mycable.de, mgreer@mvista.com
In-reply-to: <20080508.133847.74565891.nemoto@toshiba-tops.co.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.55.0805070102460.16173@cliff.in.clinika.pl> <20080508.133847.74565891.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
On Thu, 8 May 2008, Atsushi Nemoto wrote:

> For write transfer, you must use only one i2c_msg.  If two i2c_msg
> were used, the slave address is inserted between register number and
> first data.  This chip cannot accept such sequence.

 Correct, thank you for pointing it out -- verified with the datasheet.  I 
will send an updated patch separately taking other suggestions into 
account as well.

> On success, m41t80_i2c_transfer() returns positive value, but
> m41t80_transfer() should return 0.

 I think the check should be for values below zero as originally instead.  
Thanks for the point again.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>