linux-mips
[Top] [All Lists]

Re: [rtc-linux] Re: [RFC][PATCH 1/4] RTC: Class device support for persi

To: rtc-linux@googlegroups.com
Subject: Re: [rtc-linux] Re: [RFC][PATCH 1/4] RTC: Class device support for persistent clock
From: Alessandro Zummo <alessandro.zummo@towertech.it>
Date: Wed, 7 May 2008 13:49:30 +0200
Cc: dwmw2@infradead.org, Ralf Baechle <ralf@linux-mips.org>, Thomas Gleixner <tglx@linutronix.de>, Andrew Morton <akpm@linux-foundation.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1210148655.25560.825.camel@pmac.infradead.org>
Organization: Tower Technologies
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.55.0805070015360.16173@cliff.in.clinika.pl> <1210148655.25560.825.camel@pmac.infradead.org>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 07 May 2008 09:24:15 +0100
David Woodhouse <dwmw2@infradead.org> wrote:


> Ooh, shiny -- you saved me the trouble of doing this (and hopefully also
> the trouble of looking through it to check whether all the callers of
> read_persistent_clock() can sleep, etc.?)

 I knew you would have liked that patch :)
 
> One thing I was going to do in rtc_update_persistent_clock() was make it
> use mutex_trylock() for grabbing rtc->lock. We go to great lengths to
> make sure we're updating the clock at the correct time -- we don't want
> to be doing things which delay the update. So we should probably just
> use mutex_trylock() and abort the update (this time) if it fails.

 agreable. 
 
> I was also thinking of holding the RTC_HCTOSYS device open all the time,
> too. If it's a problem that you then couldn't unload the module, perhaps
> a sysfs interface to set/change/clear which device is used for this?

 mm.. let's keep it easy. the chances the rtc is in use
 are usually real low.
 

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


<Prev in Thread] Current Thread [Next in Thread>