linux-mips
[Top] [All Lists]

Re: Breakage in arch/mips/kernel/traps.c for 64bit

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: Breakage in arch/mips/kernel/traps.c for 64bit
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Sat, 3 May 2008 20:57:04 +0100 (BST)
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, tsbogend@alpha.franken.de, linux-mips@linux-mips.org
In-reply-to: <20080503173927.GA19925@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080501163314.GA9955@alpha.franken.de> <20080502101113.GA24408@linux-mips.org> <20080504.011647.93019265.anemo@mba.ocn.ne.jp> <20080503173927.GA19925@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Sat, 3 May 2008, Ralf Baechle wrote:

> Slightly cleaner:
> 
>   return KSEGX(a) == KSEG0;

 You mean:

return KSEGX(a) == KSEG0 || KSEGX(a) == KSEG1;

right?

> Unfortunately there is no such macro for the 64-bit segments nor does
> the existing KSEGX() work correctly for non-CKSEGx 64-bit addresses.

 As I mentioned there is suitable code doing exactly this in
arch/mips/lib/uncached.c and it can be extracted to an inline function to
be put in <asm/addrspace.h> to be reused here and in the future possibly
elsewhere.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>