linux-mips
[Top] [All Lists]

Re: [PATCH v2] unify sys_pipe implementation

To: Ulrich Drepper <drepper@redhat.com>
Subject: Re: [PATCH v2] unify sys_pipe implementation
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sat, 3 May 2008 11:40:18 -0700 (PDT)
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mips@linux-mips.org, sparclinux@vger.kernel.org
In-reply-to: <200805031801.m43I109q032242@devserv.devel.redhat.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200805031801.m43I109q032242@devserv.devel.redhat.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 1.10 (LFD 962 2008-03-14)

On Sat, 3 May 2008, Ulrich Drepper wrote:
> 
> Some arch maintainers might want to take a look at their remaining
> special versions.  The cris version, for instance, only differs from
> the generic version in that it takes the BKL.  Is this still needed
> these days?

No, definitely not.

That said, I think that in order to not break other architectures, and to 
make it even easier to do this transformation, how about we just mark the 
generic version with __weak?

That way, odd architectures can just continue to call their own versions 
"sys_pipe()", and we don't break them unnecessarily.

                Linus

<Prev in Thread] Current Thread [Next in Thread>