| To: | ralf@linux-mips.org |
|---|---|
| Subject: | [PATCH] [MIPS]: if() in pte_mkyoung seems to be missing braces |
| From: | "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi> |
| Date: | Fri, 2 May 2008 14:08:20 +0300 (EEST) |
| Cc: | linux-mips@linux-mips.org |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| Sender: | linux-mips-bounce@linux-mips.org |
In case this is a genuine bug, somebody else more familiar
with that stuff should evaluate it's effects (I just found it
by some shell pipeline and it seems suspicious looking).
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
include/asm-mips/pgtable.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/asm-mips/pgtable.h b/include/asm-mips/pgtable.h
index 17a7703..fc6e98b 100644
--- a/include/asm-mips/pgtable.h
+++ b/include/asm-mips/pgtable.h
@@ -232,9 +232,10 @@ static inline pte_t pte_mkdirty(pte_t pte)
static inline pte_t pte_mkyoung(pte_t pte)
{
pte.pte_low |= _PAGE_ACCESSED;
- if (pte.pte_low & _PAGE_READ)
+ if (pte.pte_low & _PAGE_READ) {
pte.pte_low |= _PAGE_SILENT_READ;
pte.pte_high |= _PAGE_SILENT_READ;
+ }
return pte;
}
#else
--
1.5.2.2
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Breakage in arch/mips/kernel/traps.c for 64bit, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH 1/11] Alchemy common headers style cleanup, Ralf Baechle |
| Previous by Thread: | Re: undefined reference to `copy_siginfo_from_user32', Giuseppe Sacco |
| Next by Thread: | Re: [PATCH 1/11] Alchemy common headers style cleanup, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |