| To: | David Daney <ddaney@avtrex.com> |
|---|---|
| Subject: | Re: [Patch 6/6] Ptrace support for HARDWARE_WATCHPOINTS. |
| From: | Daniel Jacobowitz <dan@debian.org> |
| Date: | Tue, 22 Apr 2008 12:23:43 -0400 |
| Cc: | linux-mips@linux-mips.org, linux-kernel@vger.kernel.org |
| In-reply-to: | <480D33EB.30808@avtrex.com> |
| Mail-followup-to: | David Daney <ddaney@avtrex.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <480D2151.2020701@avtrex.com> <480D33EB.30808@avtrex.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.17 (2007-12-11) |
On Mon, Apr 21, 2008 at 05:40:11PM -0700, David Daney wrote:
> +struct mips32_watch_regs {
> + unsigned int num_valid;
> + unsigned int reg_mask;
> + unsigned int irw_mask;
> + unsigned long watchlo[8];
> + unsigned int watchhi[8];
> +};
Please do not use long in new ptrace interfaces. Use either
uint32_t or uint64_t as appropriate so that it doesn't depend
on how the kernel or debugger was built.
--
Daniel Jacobowitz
CodeSourcery
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] rbtx4938: minor cleanup, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [Patch 6/6] Ptrace support for HARDWARE_WATCHPOINTS., Maciej W. Rozycki |
| Previous by Thread: | [Patch 6/6] Ptrace support for HARDWARE_WATCHPOINTS., David Daney |
| Next by Thread: | Re: [Patch 6/6] Ptrace support for HARDWARE_WATCHPOINTS., Maciej W. Rozycki |
| Indexes: | [Date] [Thread] [Top] [All Lists] |