linux-mips
[Top] [All Lists]

Re: Patches for 34K APRP

To: "Kevin D. Kissell" <kevink@mips.com>
Subject: Re: Patches for 34K APRP
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 17 Apr 2008 13:43:19 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <4805FFE6.5080903@mips.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4805FFE6.5080903@mips.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.17 (2007-11-01)
On Wed, Apr 16, 2008 at 03:32:22PM +0200, Kevin D. Kissell wrote:

>  arch/mips/kernel/setup.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index f8a535a..a6a0d62 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -336,6 +336,10 @@ static void __init bootmem_init(void)
>  #endif
>               max_low_pfn = PFN_DOWN(HIGHMEM_START);
>       }
> +     /*
> +      * Propagate final value of max_low_pfn to max_pfn
> +      */
> +     max_pfn = max_low_pfn;

That will be incorrect for systems with highmem.  So I think the right
fix is to replace all references to max_pfn in vpe.c with max_low_pfn.

It still won't play nicely with esotheric configurations such as
discontig memory ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>