| To: | Thomas Bogendoerfer <tsbogend@alpha.franken.de> |
|---|---|
| Subject: | Re: [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate_irqno() |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Thu, 17 Apr 2008 11:59:52 +0100 |
| Cc: | Roel Kluin <12o3l@tiscali.nl>, linux-mips@linux-mips.org, lkml <linux-kernel@vger.kernel.org> |
| In-reply-to: | <20080416222755.GA18832@alpha.franken.de> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <480559DC.2060807@tiscali.nl> <20080416091554.GA6026@alpha.franken.de> <480616C6.3080203@tiscali.nl> <20080416222755.GA18832@alpha.franken.de> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Thu, Apr 17, 2008 at 12:27:56AM +0200, Thomas Bogendoerfer wrote: > On Wed, Apr 16, 2008 at 05:09:58PM +0200, Roel Kluin wrote: > > Thomas Bogendoerfer wrote: > > > On Wed, Apr 16, 2008 at 03:43:56AM +0200, Roel Kluin wrote: > > >> irq is unsigned, cast to signed to evaluate the allocate_irqno() return > > >> value, > > > > >> + if ((int) irq < 0) > > > > > > Why don't you just make irq and rt_timer_irq an int ? > > > > Ok, thanks, It should be right, but I cannot test this (no hardware). > > I've tested it on real hardware. > > Acked-By: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Thanks, applied. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Alchemy: kill useless #include's, #define's and extern's (take 3), Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH] Alchemy: kill useless #include's, #define's and extern's (take 3), Sergei Shtylyov |
| Previous by Thread: | Re: [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate_irqno(), Thomas Bogendoerfer |
| Next by Thread: | [PATCH] Functional Fixes and a little reformatting of APRP Support for MIPS MT, Kevin D . Kissell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |