linux-mips
[Top] [All Lists]

Re: [PATCH 1/6] tc35815: Statistics cleanup

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: [PATCH 1/6] tc35815: Statistics cleanup
From: Jeff Garzik <jeff@garzik.org>
Date: Wed, 16 Apr 2008 20:54:11 -0400
Cc: Andy Fleming <afleming@freescale.com>, linux-mips@linux-mips.org, netdev@vger.kernel.org
In-reply-to: <20080413.001146.25909265.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20080411.002412.03977557.anemo@mba.ocn.ne.jp> <48007A41.2000803@garzik.org> <20080413.001146.25909265.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.12 (X11/20080226)
Atsushi Nemoto wrote:
On Sat, 12 Apr 2008 05:00:49 -0400, Jeff Garzik <jeff@garzik.org> wrote:
applied 1-6

Thanks.

Could you apply this too, or hopufully fold into Andy Fleming's "phy:
Change mii_bus id field to a string" patch (commit c69fedae) ?

------------------------------------------------------
Subject: [PATCH] tc35815: build fix

Fix build failure caused by Andy Fleming's "phy: Change mii_bus id
field to a string" patch.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
index 744f11f..10e4e85 100644
--- a/drivers/net/tc35815.c
+++ b/drivers/net/tc35815.c
@@ -766,7 +766,8 @@ static int tc_mii_init(struct net_device *dev)
        lp->mii_bus.name = "tc35815_mii_bus";
        lp->mii_bus.read = tc_mdio_read;
        lp->mii_bus.write = tc_mdio_write;
-       lp->mii_bus.id = (lp->pci_dev->bus->number << 8) | lp->pci_dev->devfn;
+       snprintf(lp->mii_bus.id, MII_BUS_ID_SIZE, "%x",
+                (lp->pci_dev->bus->number << 8) | lp->pci_dev->devfn);
        lp->mii_bus.priv = dev;
        lp->mii_bus.dev = &lp->pci_dev->dev;
        lp->mii_bus.irq = kmalloc(sizeof(int) * PHY_MAX_ADDR, GFP_KERNEL);

applied



<Prev in Thread] Current Thread [Next in Thread>