linux-mips
[Top] [All Lists]

Re: [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate_i

To: Roel Kluin <12o3l@tiscali.nl>
Subject: Re: [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate_irqno()
From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
Date: Thu, 17 Apr 2008 00:27:56 +0200
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, lkml <linux-kernel@vger.kernel.org>
In-reply-to: <480616C6.3080203@tiscali.nl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <480559DC.2060807@tiscali.nl> <20080416091554.GA6026@alpha.franken.de> <480616C6.3080203@tiscali.nl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.13 (2006-08-11)
On Wed, Apr 16, 2008 at 05:09:58PM +0200, Roel Kluin wrote:
> Thomas Bogendoerfer wrote:
> > On Wed, Apr 16, 2008 at 03:43:56AM +0200, Roel Kluin wrote:
> >> irq is unsigned, cast to signed to evaluate the allocate_irqno() return 
> >> value,
>  
> >> +          if ((int) irq < 0)
> > 
> > Why don't you just make irq and rt_timer_irq an int ?
> 
> Ok, thanks, It should be right, but I cannot test this (no hardware).

I've tested it on real hardware.

Acked-By: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

<Prev in Thread] Current Thread [Next in Thread>